[Kde-pim] Re: Review Request: When processing a parenthesized list, make sure there is enough data

[Robert Marmorstein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5657/
-----------------------------------------------------------

(Updated 2010-10-19 06:09:49.671684)


Review request for KDE PIM, Kevin Krammer and Kevin Ottens.


Changes
-------

Oops.  Really fix the trailing spaces. 


Summary
-------

I experienced a crash in ImapStreamParser::readParenthesizedList() that was caused by m_position becoming larger than the size of the QByteArray.  I will admit I don't understand this code thorougly, but it looks to me like the correct solution is to use the waitForMoreData function to prevent this from happening, so here is a patch that does that.  Please feel free to be critical -- I would really like to understand this code, so any comments or suggestions will be delightfully accepted as constructive feedback.


Diffs (updated)
-----

  /trunk/KDE/kdepimlibs/kimap/imapstreamparser.cpp 1187364 

Diff: http://svn.reviewboard.kde.org/r/5657/diff


Testing
-------

The imap resource used to crash pretty much every time I started kontact or kmail.  Now it doesn't.  


Thanks,

Robert

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/