[Kde-pim] Re: Review Request: Fix KMail systray clicking behavior

[George Metaxas]

> On 2010-11-24 07:24:34, Torgny Nyblom wrote:
> > Perhaps I'm missing something but from reading the diff it seems like the call to hideKmail() is forgotten, or?

Yes, but it's not needed. The activateWindow() handles both the hiding and the showing of the window. Actually, I only left the hideKMail() method in the code, because it is called by KMKernel.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5963/#review8949
-----------------------------------------------------------


On 2010-11-23 16:53:46, George  Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5963/
> -----------------------------------------------------------
> 
> (Updated 2010-11-23 16:53:46)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch fixes bug 73938, which is related to the way in which the systray icon of KMail behaves. Currently, clicking on the systray icon has the effect of minimizing the KMail window, irrespective of its position in the window stack, and maximizing it if it was previously minimized. In the latter case, the current virtual desktop is changed to the virtual desktop where the KMail window was minimized. As noted in the corresponding bug entry, this behavior is different than the corresponding behavior of other KDE applications (e.g. Akregator).
> 
> The patch modifies the behavior of the KMail systray clicking handling, by making it identical to other applications (e.g. Akregator). When the KMail window is the top level window in the virtual desktop, it is minimized. If it is visible in the desktop, but not at the top, it is brought to the top. If the window is minimized, then it is maximized to the current virtual desktop.
> 
> 
> This addresses bug 74938.
>     https://bugs.kde.org/show_bug.cgi?id=74938
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmsystemtray.h 1200012 
>   /trunk/KDE/kdepim/kmail/kmsystemtray.cpp 1200012 
> 
> Diff: http://svn.reviewboard.kde.org/r/5963/diff
> 
> 
> Testing
> -------
> 
> Tested the minimizing/maximizing behavior with both KMail and Kontact. 
> 
> 
> Thanks,
> 
> George
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/