[Kde-pim] Re: KMail filter with non-existing account apply set

[Kevin Krammer]

On Monday, 2010-11-29, Ingo Klöcker wrote:
> On Sunday 28 November 2010, Kevin Krammer wrote:
> > Hi all,
> > 
> > one of the user testing either trunk or the most recent beta found
> > some of his filters had not been migrated.
> > 
> > At first I misinterpreted it as their target folders not pointing to
> > collections but still pointing to some folder path.
> > However, it what was actually happening is that the filters got
> > removed, i.e. they were not longer in the filter dialog's list.
> > 
> > After I got the hint that all lost filters had in common that they
> > only applied to a selection of accounts, I checked the two involved
> > processes.
> > 
> > The migrator did not do anything special with this type of filter so
> > the removal had to be done in KMail.
> > And indeed it MailFilter::purify() checks the account list from the
> > filter config against the AgentManager's agent list and considers
> > all filters "empty" if none of the accounts match.
> > 
> > The fix on the migrator side has been committed here [1], i.e. after
> > successful migration of an account its old ID in filters is replaced
> > with its new one.
> > 
> > This fixes the problem for all successfully migrated accounts.
> > 
> > If we want to support the case when not all accounts can be migrated
> > at first attempt, e.g. IMAP server not accessible at time of
> > migration, then KMail should probably not discard these filters but
> > just ignore them.
> > 
> > The filter dialog could probably warn about that and/or offer to
> > modify the account selection.
> 
> I suggest removing the automatic clean-up completely. IMHO KMail
> shouldn't remove any accounts, filters, etc., without asking the user
> for approval.

Right, that's what I mean in my last sentence.

> Is the migration log easily accessible for the user so that he can check
> which settings need manual adjustments?

Actually there should't be any need for manual adjustments.
But maybe I misunderstood the question.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20101129/1ddbba6e/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/