[Kde-pim] Re: Review Request: Add XLIST ability to KIMAP::ListJob

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5928/#review8961
-----------------------------------------------------------



/trunk/KDE/kdepimlibs/kimap/listjob.h
<http://svn.reviewboard.kde.org/r/5928/#comment9680>

    What about just Option? API wise, referring to this type will be ListJob::Option anyway.



/trunk/KDE/kdepimlibs/kimap/listjob.h
<http://svn.reviewboard.kde.org/r/5928/#comment9682>

    What about IncludeFolderRoleFlags? That's what XLIST is about, returning extra flags giving the role of the mailbox (inbox, draft, etc.).


- Kevin


On 2010-11-22 10:23:19, Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5928/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 10:23:19)
> 
> 
> Review request for KDE PIM and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to list mailboxes using the XLIST command instead of LIST. XLIST is an extension to IMAP that provides localized folder names. It's prominently used by Gmail's IMAP servers.
> 
> As the ListJob currently accepts a boolean flag to specify whether we want to include unsubscribed folders, this patch also replaces this flag by a ListingOption enum. The includeUnsubscribed() / setIncludeUnsubscribed() are now convenience functions to set the appropriate enum value, marked as deprecated.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kimap/listjob.h 1199501 
>   /trunk/KDE/kdepimlibs/kimap/listjob.cpp 1199501 
> 
> Diff: http://svn.reviewboard.kde.org/r/5928/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/