[Kde-pim] Re: Review Request: When processing a parenthesized list, make sure there is enough data

[Robert Marmorstein]

> On 2010-10-19 06:31:37, Kevin Ottens wrote:
> > The patch itself sounds harmless, but I agree with Torgny here, a way to reproduce the crash would be welcome along this patch. Even better if that's an automated test so that we can check the regression doesn't reappear.
> > 
> > Sounds like something which might happen when the connection drops unexpectedly.
> 
> Robert Marmorstein wrote:
>     If I remove the patch, it will probably start crashing again.  I'm not sure to tell you how to duplicate it, though.  It seems to happen when I sync mail from my Kolab server.  I will try to figure out exactly what IMAP command is being processed and create a bug report for this stuff.
> 
> Kevin Ottens wrote:
>     Well, if you can make a unit test out of your findings it's way better than a bug report. ;-)
>     Just make the test part of your patch and I'll gladly mark it "ship it". :-)
> 
> Robert Marmorstein wrote:
>     Oddly enough, I reverted the patch (to kdepimlibs, but not to kdesupport) and not only is kmail no longer crashing -- it's actually retrieving mail successfully from the Kolab server (which is hasn't done since I switched to trunk about three months ago).  Maybe the kdesupport bug was causing my (much more serious) problem!
>     
>     (It's also possible that the svn update I just did fixed the bug, of course).

Now that I am completely unable to reproduce the bug this fixes, I am going to close out the review request.  I guess we an revisit it if similar behavior shows up again.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5657/#review8222
-----------------------------------------------------------


On 2010-10-19 06:09:49, Robert Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5657/
> -----------------------------------------------------------
> 
> (Updated 2010-10-19 06:09:49)
> 
> 
> Review request for KDE PIM, Kevin Krammer and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> I experienced a crash in ImapStreamParser::readParenthesizedList() that was caused by m_position becoming larger than the size of the QByteArray.  I will admit I don't understand this code thorougly, but it looks to me like the correct solution is to use the waitForMoreData function to prevent this from happening, so here is a patch that does that.  Please feel free to be critical -- I would really like to understand this code, so any comments or suggestions will be delightfully accepted as constructive feedback.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kimap/imapstreamparser.cpp 1187364 
> 
> Diff: http://svn.reviewboard.kde.org/r/5657/diff
> 
> 
> Testing
> -------
> 
> The imap resource used to crash pretty much every time I started kontact or kmail.  Now it doesn't.  
> 
> 
> Thanks,
> 
> Robert
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/