[Kde-pim] Review Request: Enable KDE_ENABLE_FINAL to the same extent as in 4.5

Will Stephenson wstephenson at kde.org
Sun Nov 21 21:16:07 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5919/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Fix multiple declarations of the same symbol in files in the same directory that become part of the same compilation unit when cmake'd with -DKDE_ENABLE_FINAL=1. (Except in gpgmepp)


Diffs
-----

  trunk/KDE/kdepimlibs/akonadi/agentactionmanager.cpp 1199406 
  trunk/KDE/kdepimlibs/akonadi/contact/actions/dialphonenumberaction.cpp 1199406 
  trunk/KDE/kdepimlibs/akonadi/contact/actions/sendsmsaction.cpp 1199406 
  trunk/KDE/kdepimlibs/akonadi/metatypes.h PRE-CREATION 
  trunk/KDE/kdepimlibs/akonadi/standardactionmanager.cpp 1199406 
  trunk/KDE/kdepimlibs/kcalcore/icalformat_p.cpp 1199406 
  trunk/KDE/kdepimlibs/kcalcore/vcalformat.cpp 1199406 

Diff: http://svn.reviewboard.kde.org/r/5919/diff


Testing
-------

Clean builds of kdepimlibs both with and without KDE_ENABLE_FINAL.


Thanks,

Will

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list