[Kde-pim] Re: Review Request: Add XLIST ability to KIMAP::ListJob

[Kevin Ottens]

> On 2010-11-22 16:43:29, Torgny Nyblom wrote:
> > Come to think of it why add optional support for using the XLIST command instead of integrating this so that if the server supports XLIST always use it instead of LIST and use LIST as a fall back?
> 
> Gregory Schlomoff wrote:
>     We discussed that on #akonadi, and the position from the lead developers of KIMAP was that it's a relatively low-level library, and that it should not do this kind of optimization.
> 
> Torgny Nyblom wrote:
>     Guess Kevin and I disagree on that point :) Especially since there already is this sort of optimization in KIMAP (the UIDLPLUS extension).

There no such optimization regarding UIDPLUS. It's just that if we get extra info because of UIDPLUS, we cache it immediately. That's different from triggering automatically commands based on the supported extensions (we actually can't even detect that from the jobs).

Besides in the case of XLIST, since it has no XLSUB counterpart (totally stupid IMO but we can't do anything about that) the client needs to explicitely know what it's using.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5928/#review8898
-----------------------------------------------------------


On 2010-11-22 10:23:19, Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5928/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 10:23:19)
> 
> 
> Review request for KDE PIM and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to list mailboxes using the XLIST command instead of LIST. XLIST is an extension to IMAP that provides localized folder names. It's prominently used by Gmail's IMAP servers.
> 
> As the ListJob currently accepts a boolean flag to specify whether we want to include unsubscribed folders, this patch also replaces this flag by a ListingOption enum. The includeUnsubscribed() / setIncludeUnsubscribed() are now convenience functions to set the appropriate enum value, marked as deprecated.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kimap/listjob.h 1199501 
>   /trunk/KDE/kdepimlibs/kimap/listjob.cpp 1199501 
> 
> Diff: http://svn.reviewboard.kde.org/r/5928/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/