[Kde-pim] Re: Review Request: Enable KDE_ENABLE_FINAL to the same extent as in 4.5

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5919/#review8890
-----------------------------------------------------------

Ship it!


You're way better at this then I am, but still looks good to me (at least from a quick look at the diff ;) )

- Torgny


On 2010-11-21 21:16:06, Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5919/
> -----------------------------------------------------------
> 
> (Updated 2010-11-21 21:16:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fix multiple declarations of the same symbol in files in the same directory that become part of the same compilation unit when cmake'd with -DKDE_ENABLE_FINAL=1. (Except in gpgmepp)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/agentactionmanager.cpp 1199406 
>   trunk/KDE/kdepimlibs/akonadi/contact/actions/dialphonenumberaction.cpp 1199406 
>   trunk/KDE/kdepimlibs/akonadi/contact/actions/sendsmsaction.cpp 1199406 
>   trunk/KDE/kdepimlibs/akonadi/metatypes.h PRE-CREATION 
>   trunk/KDE/kdepimlibs/akonadi/standardactionmanager.cpp 1199406 
>   trunk/KDE/kdepimlibs/kcalcore/icalformat_p.cpp 1199406 
>   trunk/KDE/kdepimlibs/kcalcore/vcalformat.cpp 1199406 
> 
> Diff: http://svn.reviewboard.kde.org/r/5919/diff
> 
> 
> Testing
> -------
> 
> Clean builds of kdepimlibs both with and without KDE_ENABLE_FINAL.
> 
> 
> Thanks,
> 
> Will
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/