[Kde-pim] Review Request: New config file "kmail2rc" for KMail2

[Kevin Krammer]

> On 2010-05-31 22:38:19, Thomas McGuire wrote:
> > You need to change the files in kdepim/kmail/kconf_update as well, they reference kmailrc.
> > What about $KDEHOME/share/apps/kmail? Won't that be apps/kmail2 now? Is KMail 2/the migrator still able to cope with data in apps/kmail?

Hmm. How do the kconf_update things work?
I was kind of hoping that they would be run before the migrator, thus updating kmailrc as required which would then be used as a base for the migrator.

By changing the appname KStandardDirs resource "appdata" will indeed point to apps/kmail2. Does KMail store anything in there other than mail?
Mail will be dealt with by the migrator, which explicitly looks in apps/kmail, but if there is anything else in there that should be dealt with accordingly IMHO.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4186/#review5926
-----------------------------------------------------------


On 2010-05-31 14:22:37, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4186/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 14:22:37)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Use kmail2rc as the config file for KMail2.
> Allows to e.g. rerun the migration
> 
> Tried to make it work without the change in AppData, but KGlobal::config() always points to the "appname"rc file
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/aboutdata.cpp 1132828 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1132828 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 1132828 
>   /trunk/KDE/kdepim/kontact/src/mainwindow.cpp 1132828 
>   /trunk/KDE/kdepim/runtime/accountwizard/ldap.cpp 1132828 
>   /trunk/KDE/kdepim/runtime/migration/kmail/kmailmigrator.cpp 1132828 
> 
> Diff: http://reviewboard.kde.org/r/4186/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/