[Kde-pim] Review Request: use single query in ItemRetriever

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3876/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

This patch makes the ItemRetriever use a single SQL query with LeftJoins to achieve the same as before.

This won't reduce the overall query time, since the same amount of items will be retrieved.
But imo it makes the code much cleaner and also enables us to do some optimizations in the future:

- data.isNull directly in the query
- item retrieval from the resource for lists of items, not only single items


Diffs
-----

  /trunk/kdesupport/akonadi/server/src/storage/itemretriever.h 1122080 
  /trunk/kdesupport/akonadi/server/src/storage/itemretriever.cpp 1122080 
  /trunk/kdesupport/akonadi/server/src/storage/querybuilder.h 1122080 
  /trunk/kdesupport/akonadi/server/src/storage/querybuilder.cpp 1122080 

Diff: http://reviewboard.kde.org/r/3876/diff


Testing
-------

ran cachetest unit tests in pimlibs without regressions, but there are a few other failing tests
where I have yet to validate that they are no regressions. I think the patch can be reviewed
right now though, hence this request.


Thanks,

Milian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/