[Kde-pim] Review Request: Port KAlarm to KStatusNotifierItem

[David Jarvie]

> On 2010-05-22 23:50:04, David Jarvie wrote:
> > Despite building trunk from scratch twice, I can't get KAlarm to run (with or without your patch) - I suspect it's to do with package conflicts. So I've tried your latest patch on KDE 4.4, but the icon still doesn't change when alarms are disabled.
> 
> David Jarvie wrote:
>     I finally managed to get KAlarm trunk to run, by setting up a new user. Your patch seems to work ok now. However, I'd prefer the disabled icon, and particularly the part-disabled icon, to remain as they are already. You can download my versions at http://www.astrojar.org.uk/linux/download/ - ox22-action-kalarm-disabled.png and ox22-action-kalarm-partdisabled.png.

I just noticed that disabling the display of the system tray icon (using View -> Show in System Tray) doesn't work - the icon stays visible.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3374/#review5838
-----------------------------------------------------------


On 2010-05-18 09:32:36, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3374/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 09:32:36)
> 
> 
> Review request for KDE PIM and David Jarvie.
> 
> 
> Summary
> -------
> 
> This is a port of KAlarm from KSystemTrayIcon to KStatusNotifierItem. Note that it makes use of overlays, so I created (warning, hacker "art"!) two emblems for it, which you can download here:
> http://people.canonical.com/~agateau/tmp/ox8-emblems-disabled.png
> http://people.canonical.com/~agateau/tmp/ox8-emblems-partdisabled.png
> 
> The emblems should be placed in kalarm/pixmaps/
> 
> (The ox22-emblems-partdisabled.png file from this dir can be removed)
> 
> Unfortunately, there is no way for a KStatusNotifierItem to be notified when the tooltip is about to be displayed so I had to resort to add code which updates the tooltip whenever necessary.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1126658 
>   trunk/KDE/kdepim/kalarm/kalarmconfig.kcfg 1126658 
>   trunk/KDE/kdepim/kalarm/mainwindow.cpp 1126658 
>   trunk/KDE/kdepim/kalarm/traywindow.h 1126658 
>   trunk/KDE/kdepim/kalarm/traywindow.cpp 1126658 
> 
> Diff: http://reviewboard.kde.org/r/3374/diff
> 
> 
> Testing
> -------
> 
> - Created tasks, disabled some of them, disabled the whole of kalarm: icon was correctly updated.
> - Checked the tooltip is always up to date, including when it is setup to show the remaining time of an alarm and including following tooltip preferences changes.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/