[Kde-pim] Review Request: Add support to backup a PostgreSQL database

[Brian DeRocher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3350/
-----------------------------------------------------------

(Updated 2010-03-24 00:16:40.488773)


Review request for KDE PIM.


Changes
-------

* Resolve issues in http://reviewboard.kde.org/r/3350/#review4631
* Rename dumpDb() to dumpDatabase().
* Rename getRequiredExecutables() to requredExectuables().
* Insert and remove whitespace where needed.
* Alphabetize included files.
* dumpFilename and exe are const.
* Consolidate and remove variable reqs.

See here for just latest changes: https://derocher.org/kde/trac/changeset/45


Summary
-------

Created derived classes BackupMySQL and BackupPostgreSQL of Backup.  Most of work remains in Backup.  Required executables becomes a set of strings.  Derived classes may append to the set.  MySQL uses mysqldump.  PG uses pg_dump.  Global was updated to parse either a MySQL or PostgreSQL section.  BackupAssistant will create the proper derived class object.

This patch is broken down into a series of smaller patches which may be easier to review.  It's located here https://derocher.org/kde/trac/changeset/31 It goes up to revision 43.


This addresses bug 227970.
    https://bugs.kde.org/show_bug.cgi?id=227970


Diffs (updated)
-----

  /trunk/KDE/kdepim/runtime/tray/CMakeLists.txt 1105514 
  /trunk/KDE/kdepim/runtime/tray/backup.h 1105514 
  /trunk/KDE/kdepim/runtime/tray/backup.cpp 1105514 
  /trunk/KDE/kdepim/runtime/tray/backupassistant.cpp 1105514 
  /trunk/KDE/kdepim/runtime/tray/global.h 1105514 
  /trunk/KDE/kdepim/runtime/tray/global.cpp 1105514 

Diff: http://reviewboard.kde.org/r/3350/diff


Testing
-------

Successfully backed up a PostgreSQL database.  I did not test MySQL.


Thanks,

Brian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/