[Kde-pim] Review Request: Don't crash after saving message

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3446/#review4801
-----------------------------------------------------------

Ship it!


The general principle is ok, thanks for the patch. I added two small comments below.
Please commit after changing those.

(Well the general principle sucks, but that's the only way to deal with the issue until KMail is ported to Akonadi. This is a long standing KMail architectural problem)


branches/kdepim/enterprise/kdepim/kmail/kmcommands.h
<http://reviewboard.kde.org/r/3446/#comment4287>

    Why not make this a simple QList<KMMsgBase*>, and only add messages to unget to it?



branches/kdepim/enterprise/kdepim/kmail/kmcommands.cpp
<http://reviewboard.kde.org/r/3446/#comment4288>

    const bool, please


- Thomas


On 2010-03-30 12:33:41, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3446/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 12:33:41)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Right click on a message, save as mbox, then press r to reply => Crash
> 
> The message is being deleted inside the KMSaveMsgCommand
> 
> 
> This addresses bugs 216981 and kolab/issue3099.
>     https://bugs.kde.org/show_bug.cgi?id=216981
>     https://bugs.kde.org/show_bug.cgi?id=kolab/issue3099
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise/kdepim/kmail/kmcommands.h 1108738 
>   branches/kdepim/enterprise/kdepim/kmail/kmcommands.cpp 1108738 
> 
> Diff: http://reviewboard.kde.org/r/3446/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/