[Kde-pim] Review Request: akonadi krazy fixes, Check for strings used improperly or should be i18n.

Volker Krause vkrause at kde.org
Wed Mar 24 07:55:03 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3379/#review4652
-----------------------------------------------------------

Ship it!


Looks correct as well, I'm wondering why this is not caught by the compiler though, since we are setting QT_NO_CAST_FROM_ASCII IIRC.

- Volker


On 2010-03-24 06:23:30, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3379/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 06:23:30)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Turns strings passed to QString::startsWith() into QLatin1String objects.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/control/agentmanager.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/control/agenttype.cpp 1106897 
> 
> Diff: http://reviewboard.kde.org/r/3379/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Glen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list