[Kde-pim] Review Request: akonadi krazy fixes, Check for proper include directives.

Volker Krause vkrause at kde.org
Wed Mar 24 07:59:26 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3381/#review4654
-----------------------------------------------------------

Ship it!


Ok to commit as well, except the changes to the Nepomuk code as explained below.


/trunk/kdesupport/akonadi/server/src/search/dbusoperators.h
<http://reviewboard.kde.org/r/3381/#comment4166>

    The code in server/src/search is a verbatim copy of Nepomuk code, so I'd rather not modify it just for cosmetic reasons.


- Volker


On 2010-03-24 06:33:28, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3381/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 06:33:28)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fixes up include directives and guards.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/libs/tests/notificationmessagetest.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/control/controlmanager.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/shared/akapplication.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/src/handler/akappend.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/src/nepomukmanager.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/src/nepomuksearch.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/src/preprocessorinstance.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/preprocessormanager.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/search/dbusoperators.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/search/querymetatype.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/search/queryserviceclient.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/search/result.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/storage/itemretrievalmanager.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/storage/itemretrievalthread.h 1106897 
>   /trunk/kdesupport/akonadi/server/tests/unittest/handlerhelpertest.cpp 1106897 
>   /trunk/kdesupport/akonadi/server/tests/unittest/imapstreamparsertest.h 1106897 
>   /trunk/kdesupport/akonadi/server/tests/unittest/scopetest.cpp 1106897 
> 
> Diff: http://reviewboard.kde.org/r/3381/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Glen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list