[Kde-pim] Review Request: Escape quotes in SPARQL queries

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3294/#review4508
-----------------------------------------------------------


Please do not add hand-crafted code for escaping. Your patch does not handle '\' in the query. There are dedicated helper functions dealing with escaping, e.g. http://doc.trolltech.com/4.6/qsqldriver.html#escapeIdentifier. I bet there is a helper functions which does the escaping for SPARQL.

- Ingo


On 2010-03-15 09:08:59, Trever Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3294/
> -----------------------------------------------------------
> 
> (Updated 2010-03-15 09:08:59)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> For some reason, nepomuk was trying to search for ""wm161 at wm161.net"@mail.mxes.net". That has bad quotes, so this patch escapes them.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/nepomuk_email_feeder/shared/sparqlbuilder.cpp 1103287 
>   /trunk/KDE/kdepim/runtime/agents/nepomukfeeder/sparqlbuilder.cpp 1103287 
> 
> Diff: http://reviewboard.kde.org/r/3294/diff
> 
> 
> Testing
> -------
> 
> Compiled and ran without any query errors.
> 
> 
> Thanks,
> 
> Trever
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/