[Kde-pim] Review Request: Krazy fixes for kdepim/kjots, category qclasses

[Stephen Kelly]

> On 2010-03-23 11:39:16, Stephen Kelly wrote:
> > Looks good. Please commit.
> 
> Lasse Liehu wrote:
>     I don't still have an SVN account so could you or someone commit it for me?

Could you close this request, now that it's been committed?


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3353/#review4623
-----------------------------------------------------------


On 2010-03-23 11:07:53, Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3353/
> -----------------------------------------------------------
> 
> (Updated 2010-03-23 11:07:53)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This fixes those Krazy issues in category qclasses (for kdepim/kjots) that can be fixed. Also it seemed m_widget in KJotsPart wasn't used at all so I removed it. It seems component member is used instead.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsbrowser.h 1106497 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsbrowser.cpp 1106497 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotspart.h 1106497 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotswidget.h 1106497 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotswidget.cpp 1106497 
> 
> Diff: http://reviewboard.kde.org/r/3353/diff
> 
> 
> Testing
> -------
> 
> It compiles and doesn't give warnings. Also the application starts and I can type something to a page. Pretty much nothing so to say.
> 
> 
> Thanks,
> 
> Lasse
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/