[Kde-pim] Review Request: akonadi krazy fixes, Check for C++ ctors that should be declared 'explicit'

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3382/#review4655
-----------------------------------------------------------

Ship it!


Ok to commit with the modifications mentioned below.


/trunk/kdesupport/akonadi/server/src/search/result.h
<http://reviewboard.kde.org/r/3382/#comment4168>

    this one should be explicit



/trunk/kdesupport/akonadi/server/src/search/result.h
<http://reviewboard.kde.org/r/3382/#comment4167>

    explicit is pointless for copy ctors, so this one is not needed


- Volker


On 2010-03-24 06:36:02, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3382/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 06:36:02)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Makes two constructors explicit as recommended by krazy.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/search/result.h 1106897 
>   /trunk/kdesupport/akonadi/server/src/storage/transaction.h 1106897 
> 
> Diff: http://reviewboard.kde.org/r/3382/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Glen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/