[Kde-pim] Review Request: Akonadi selt test for PostgreSQL should not connect as user akonadi

[Tobias Koenig]

On Sun, Mar 21, 2010 at 08:30:39PM -0000, Brian DeRocher wrote:

Hej Brian,

>   trunk/KDE/kdepimlibs/akonadi/selftestdialog.cpp 1105514 

Instead of

  if(username != notNeeded)

you should use

  if ( !username.isEmpty() )

(also note the coding style ;)) and the same for the
password check.

Looks good otherwise, thanks!

> I have not run a regression test, but would be glad to if someone shows me how.
Make sure you compiled kdepimlibs/akonadi with 'BUILD_TESTS = on' (this is a cmake option).
Afterwards chdir into kdepimlibs/akonadi/tests and execute 'make test', this will run all
unit tests. However there could be some wrong results because of some race conditions that
haven't been fixed yet.

Ciao,
Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100321/de761ac5/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/