[Kde-pim] Review Request: Always connect to monitor item signals independent of initial fetch scope
Kevin Krammer
kevin.krammer at gmx.at
Thu Jun 17 15:51:18 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4368/
-----------------------------------------------------------
Review request for KDE PIM and Stephen Kelly.
Summary
-------
The item fetch scope could be set after the ETM's contructor has been executed, e.g. ChangeRecorder being created in a base class and derived classes setting fetch scope depending on data type.
If item monitoring should really be switched off, this can be done explicitly using setItemPopulationStrategy( NoItemPopulation )
If ItemFetchScope stays empty, all items will of course only have the data which is part of the notifications, e.g. id, remoteId, mimeType
But then that's what the fetch scope is for
Diffs
-----
/trunk/KDE/kdepimlibs/akonadi/entitytreemodel_p.cpp 1139172
Diff: http://reviewboard.kde.org/r/4368/diff
Testing
-------
Thanks,
Kevin
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list