[Kde-pim] Review Request: New config file "kmail2rc" for KMail2

[Ingo Klöcker]

> On 2010-05-31 22:05:49, Ingo Klöcker wrote:
> > I wonder whether it makes sense to define "kmail2rc" in a central place (at least for the three KMail source files).
> 
> Kevin Krammer wrote:
>     Good point.
>     
>     Or maybe using KGlobal::config() when the object is needed and KGlobal::config()->name() when the filename is needed.
>     Then the only determining factor is the appname given to the component data

I think "kmailrc" is used explicitly because KGlobal::config() will point to "kontactrc" if KMail is running inside of Kontact. I might be wrong though.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4186/#review5924
-----------------------------------------------------------


On 2010-06-01 17:07:27, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4186/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 17:07:27)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Use kmail2rc as the config file for KMail2.
> Allows to e.g. rerun the migration
> 
> Tried to make it work without the change in AppData, but KGlobal::config() always points to the "appname"rc file
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/aboutdata.cpp 1133377 
>   /trunk/KDE/kdepim/kmail/kconf_update/kmail.upd 1133377 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1133377 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 1133377 
>   /trunk/KDE/kdepim/kontact/src/mainwindow.cpp 1133377 
>   /trunk/KDE/kdepim/runtime/accountwizard/ldap.cpp 1133377 
> 
> Diff: http://reviewboard.kde.org/r/4186/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/