[Kde-pim] Review Request: kmail - please add ability to display and sort by date received

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4337/#review6152
-----------------------------------------------------------


Industry standard? If it is a standard then I'm sure you can tell us where this this standard is defined. For all I know the format of the Received header is completely undefined (although there is kind of a defacto standard used by most MTAs). If anything is an industry standard then it's the Date header which is defined in _the_ standard for email (RFC 2822). And, BTW, the Date header is a mandatory (!!!) header. All legitimate mail I receive has proper Date headers. Only spam very often does not have proper Date headers, but that's hardly a reason to change KMail's behavior.

I suggest rejecting your patch.

- Ingo


On 2010-06-16 01:03:47, Eric Sanford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4337/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 01:03:47)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> KMail should have the ability to extract the date from the Received header field, display the date received and sort by date received. A significant number of emails have incorrect or missing Date header fields. When sorting by Date in KMail, these drop to the bottom as Unknown or appear at the top if the Date header field contains a future date. This is a basic patch to extract the date from the Received header field, add a Date Received column in KMail classic theme, and sort by Date Received in classic theme. This is industry-standard for comparable email applications.
> 
> 
> This addresses bug 227942.
>     https://bugs.kde.org/show_bug.cgi?id=227942
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/messagelist/core/item.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/item.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/item_p.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/manager.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/model.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/sortorder.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/sortorder.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/theme.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/theme.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/themedelegate.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/view.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/storagemodel.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/utils/themeeditor.cpp 1137450 
>   trunk/KDE/kdepim/nepomuk_email_feeder/messageanalyzer.cpp 1137450 
>   trunk/KDE/kdepimlibs/kmime/kmime_headers.h 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_headers.cpp 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_headers_p.h 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_message.h 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_message.cpp 1137426 
> 
> Diff: http://reviewboard.kde.org/r/4337/diff
> 
> 
> Testing
> -------
> 
> This patch has been tested on openSUSE 11.2 and openSUSE 11.3 Milestone 7. The attached patch is currently being tested on openSUSE 11.3 Milestone 7, with KDE executables and libraries built from trunk/KDE (revision 1137426) source code for kdelibs, kdepimlibs, kdebase and kdepim, and trunk/kdesupport source code for attica, soprano, polkit-qt, and akonadi.
> 
> 
> Thanks,
> 
> Eric
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/