[Kde-pim] Review Request: Don't create duplicate ical/vcard resources on first run

Sergio Martins iamsergio at gmail.com
Tue Jun 22 17:21:31 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4439/#review6238
-----------------------------------------------------------


better use a proper lock inside FirstRunner, there are other places that my solution doesn't protect

- Sergio


On 2010-06-22 09:21:19, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4439/
> -----------------------------------------------------------
> 
> (Updated 2010-06-22 09:21:19)
> 
> 
> Review request for KDE PIM and Volker Krause.
> 
> 
> Summary
> -------
> 
> Two ServerManager instances, both receive typeAdded( const Akonadi::AgentType& ), and both can create a couple of FirstRunners almost at the same time, then we end up with doubled resources.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/servermanager.cpp 1141181 
> 
> Diff: http://reviewboard.kde.org/r/4439/diff
> 
> 
> Testing
> -------
> 
> Nuking everything and starting korg
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list