[Kde-pim] KDE/kdepim/runtime/resources/kolabproxy

[Volker Krause]

On Tuesday 15 June 2010 16:28:53 Casey Link wrote:
> SVN commit 1138275 by link:
>
> warning "unused variable ‘job’" --> looks like a connect() is missing.
> Please verify

I think this is wrong, the comment three lines above says "if that fails [...] 
we don't care". With your change it will now trigger a collection tree sync 
in case of an error. 

regards
Volker

>  M  +1 -0      kolabproxyresource.cpp
>
>
> --- trunk/KDE/kdepim/runtime/resources/kolabproxy/kolabproxyresource.cpp
> #1138274:1138275 @@ -595,6 +595,7 @@
>      // if that fails it's not in our tree -> we don't care
>      Collection kolabCollection = createCollection( collection );
>      CollectionModifyJob *job = new CollectionModifyJob( kolabCollection,
> this ); +    connect( job, SIGNAL(result(KJob*)),
> SLOT(kolabFolderChangeResult(KJob*)) ); } else {
>      // Kolab folder we already have in our tree, if the update fails,
> reload our tree Collection kolabCollection = createCollection( collection
> );
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100616/31a62c92/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/