[Kde-pim] [PATCH] backport of contact autocompletion for kmail 4.4

[Kevin Krammer]

On Friday, 2010-06-25, Tobias Koenig wrote:
> On Fri, Jun 25, 2010 at 11:54:00AM +0200, Kevin Krammer wrote:
> > Hi Tobias,
> 
> Hej Kevin,
> 
> > > Any objections to commit these patches to 4.4 branch to get them
> > > included into the 4.4.5 release?
> > 
> > I agree on this being a regression and having to be fixed. However, I
> > think that adding to the public API should still be avoided.
> > The headers will end up in the development packages, people looking at
> > them might thing that this is 4.4 API.
> > 
> > You might have to copy the classes to KDEPIM and modify them there :(
> 
> True, shouldn't be a problem, will do so and provide new patches!

Looks good now.
Maybe make the two headers end in _p.h, just to be sure.

> > On the code itself: in "perform search", wouldn't it make sense to check
> > if a search for the same string is already running to avoid starting the
> > same search again?
> > 
> > It also seems to not clear the result of the previous search, but I could
> > have misunderstood that part.
> 
> Well, that's actually a 1:1 copy of our code in KDE trunk, I haven't
> changed anything ;)

Ah, I see.
Could probably be improved there as well :)

Another thing: slotAkonadiSearchResult() might be done even simple by only 
casting to ItemSearchJob, right?
The casting to the specific subclasses is only needed for the debug output and 
that could be done like this:

kDebug() << job->metaObject()->className() << "found" << job->items().count() 
<< "matches";

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100625/75787251/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/