[Kde-pim] Review Request: New config file "kmail2rc" for KMail2

[Thomas McGuire]

> On 2010-05-31 22:38:19, Thomas McGuire wrote:
> > You need to change the files in kdepim/kmail/kconf_update as well, they reference kmailrc.
> > What about $KDEHOME/share/apps/kmail? Won't that be apps/kmail2 now? Is KMail 2/the migrator still able to cope with data in apps/kmail?
> 
> Kevin Krammer wrote:
>     Hmm. How do the kconf_update things work?
>     I was kind of hoping that they would be run before the migrator, thus updating kmailrc as required which would then be used as a base for the migrator.
>     
>     By changing the appname KStandardDirs resource "appdata" will indeed point to apps/kmail2. Does KMail store anything in there other than mail?
>     Mail will be dealt with by the migrator, which explicitly looks in apps/kmail, but if there is anything else in there that should be dealt with accordingly IMHO.

Here is what I see in my appdata folder:
- RC files like kmcomposerui.rc: The user can change the toolbar, that is stored here. Also, it contains changed shortcuts
- autosave files (the composer auto-saves its content every few minutes and when it crashes)
- search folder definitions (IMHO we don't need to migrate them, not a wildly used feature due to slowness)
- POP3 files: Two things: Info for on-server filtering and for leaving messages on the server.
  Filename here is something like Thomas.McGuire at gmx.net:@pop.gmx.net:995
  On server filtering: Defines which mails were marked for "download later" for POP3 servers. The POP3 resource does not have that feature at the moment. 
  Leaving messages on the server: Stores the seen UID list, which prevents duplicate mails when the function to leave messages on the server is activated. This needs  
                                  to be migrated I think, to prevent users from getting lots of duplicates. The keys in this files are seenUidList and 
                                  seenUidTimeList, the same keys exist in the config file for the POP3 resource (under a different group)
- list of unfiltered IMAP mails: Something from the filtering system for IMAP, it stores the UIDs of not yet filtered messages, so they can be filtered later. I think 
  this prevents unwanted filtering of all IMAP mails, so the filtering system knows to only filter the new mails. File name here is something like 
  unfiltered.1002413534. Can be ignored I guess, however we still need to find a working solution for this for the filtering system in general.
- A lock file to prevent duplicate kmail startup (apparently KUniqueApplication is not good enough). Can be ignored.
- Some temporary store for the filtering system which stores the messages currently in the process of being filtered. Can be ignored.


kconf_update is the preferred way to migrate/update settings in config files in normal cases. Basically the files contain rules or even scripts that change the layout of config files. Usually that is used when making minor adjustments to config files that would otherwise break config compatibility. The update rules/scripts are automatically executed as soon as the files are installed, or when the application starts.
See http://techbase.kde.org/Development/Tools/Using_kconf_update.
Please change those rules to work on kmail2rc, as we will probably adding rules later in the lifetime in KMail 2, and it would be surprising if they changed the wrong file.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4186/#review5926
-----------------------------------------------------------


On 2010-05-31 14:22:37, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4186/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 14:22:37)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Use kmail2rc as the config file for KMail2.
> Allows to e.g. rerun the migration
> 
> Tried to make it work without the change in AppData, but KGlobal::config() always points to the "appname"rc file
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/aboutdata.cpp 1132828 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1132828 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 1132828 
>   /trunk/KDE/kdepim/kontact/src/mainwindow.cpp 1132828 
>   /trunk/KDE/kdepim/runtime/accountwizard/ldap.cpp 1132828 
>   /trunk/KDE/kdepim/runtime/migration/kmail/kmailmigrator.cpp 1132828 
> 
> Diff: http://reviewboard.kde.org/r/4186/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/