[Kde-pim] Review Request: Emit change notifications for subscribe/unsubscribe

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4770/#review6736
-----------------------------------------------------------


Technically both your patches look correct to me, but see the inline comments for ways to make it a bit cleaner.


/trunk/kdesupport/akonadi/server/src/handler/subscribe.cpp
<http://reviewboard.kde.org/r/4770/#comment6518>

    I know (ab)using the changed field was my initial suggestion, but a cleaner way might be to extend the NotificationMessage::Operation enum for subscribe/unsubscribe instead. Sorry, just realized that when reading the patch and after writing some Monitor unit tests. 



/trunk/kdesupport/akonadi/server/src/handler/subscribe.cpp
<http://reviewboard.kde.org/r/4770/#comment6517>

    NotificationCollector does not emit notifications as long as a transaction is in progress, so you could just as well do this in the while loop above.


- Volker


On 2010-07-28 15:43:41, Leo Franchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4770/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 15:43:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When subscribing or unsubscribing from a collection, there is no notification. This creates a new collection change notification with SUBSCRIBE or UNSUBSCRIBE in the parts list, that the monitor then translates to signals. 
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/handler/subscribe.cpp 1155565 
>   /trunk/kdesupport/akonadi/libs/protocol_p.h 1155565 
> 
> Diff: http://reviewboard.kde.org/r/4770/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/