[Kde-pim] Review Request: Convert IMAP flags to internal Akonadi flags in the IMAP resource.

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4760/
-----------------------------------------------------------

(Updated 2010-07-26 17:53:17.266172)


Review request for KDE PIM and Kevin Ottens.


Changes
-------

Thanks for the comments. Forgot the init code in the constructor from before I made it static... thanks. I've switched to your recommendation of a  simple if-else cascade, as this can be called many times. 


Summary
-------

As a result of the recent Akonadi server changes that have made the akonadi server case-sensitive for flags, the decision was made to store flags as all-uppercase. However, the flags from imap servers are not upper-cased, they are simply capitalized. This results in collection statistics always being incorrect (listing all items as unread).

After discussion with Tobias, a solution was proposed to do a mapping of KImap flags <--> Akonadi flags in the imap resource, as that is the interface between KImap and Akonadi. For now this just includes 4 standard imap server flags. I don't know if this is the best way to do this, but figured i'd throw it out there and start a discussion.

 Comments are appreciated :)


Diffs (updated)
-----

  /branches/KDE/4.5/kdepim/runtime/resources/imap/imapresource.h 1154848 
  /branches/KDE/4.5/kdepim/runtime/resources/imap/imapresource.cpp 1154848 

Diff: http://reviewboard.kde.org/r/4760/diff


Testing
-------


Thanks,

Leo

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/