[Kde-pim] POP3 KioSlave unreliable - please apply fix

[Thomas McGuire]

Hi Sven-Ola,

On Saturday 17 July 2010 10:24:38 Sven-Ola Tuecke wrote:
> recently upgraded to Kubuntu/Lynx (from Hardy, I'm now on Kmail-1.13.2, KDE
> 4.4.2). Noticed a sporadic message box stating "Could not read file Invalid
> response from server:" and a single dot as "wrong".
> 
> Took me some time to include debug code in order to find the root cause:
> the POP3 ioslave uses memcpy() to move the input buffer while src and dst
> overlaps. This in turn leads to e.g. the last 3 bytes of the buffer
> (.^M^J) to overwrite the buffer start -> boinks. Overlapping memcpy() has
> unpredictable results and a simple replacement by memmove() repairs that.
> 
> I write to this list, because the bugtracker does not indicate a vivid
> devel response, e.g. https://bugs.kde.org/show_bug.cgi?id=232245 is marked
> as fixed while bug still exists. A patch replacing 2 times memmove() in
> kioslave/pop3/pop3.cpp can be found on
> https://bugs.kde.org/show_bug.cgi?id=230072 but I'm pretty shure that also
> other bugreps are triggered by this, e.g. one my scan this list.
> https://bugs.kde.org/buglist.cgi?quicksearch=pop3

First of all, sorry for the late reply.
Thank you very much for the patch! It seems like finding the defect in this 
case was not easy, well done.
I've committed your patch now to the 4.4 branch, the 4.5 branch and trunk, 
starting with r1156867 [1].
Also, I fixed the confusing error message "Could not read file Invalid
response from server:" with r1156874 [2], but only in trunk, because the 
branches are in string freeze.

Thanks,
Thomas

[1] http://websvn.kde.org/?revision=1156867&view=revision
[2] http://websvn.kde.org/?revision=1156874&view=revision
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100730/624d763d/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/