[Kde-pim] Review Request: Use square photos for contacts

chris at ilovelinux.de chris at ilovelinux.de
Tue Jul 13 16:44:55 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4596/
-----------------------------------------------------------

(Updated 2010-07-13 15:44:54.835623)


Review request for KDE PIM and Tobias Koenig.


Changes
-------

update patch to contain all occurences of the border selection size.


Summary
-------

This patch changes the image region selection border to square, as this is the only way to get sync with mobile devices working. It also seems to be the standard in vcard.


This addresses bug 242764.
    https://bugs.kde.org/show_bug.cgi?id=242764


Diffs (updated)
-----

  /trunk/KDE/kdepimlibs/akonadi/contact/editor/imagewidget.cpp 1149523 
  /trunk/KDE/kdepimlibs/akonadi/contact/contactgroupviewer.cpp 1149523 
  /trunk/KDE/kdepimlibs/akonadi/contact/contactviewer.cpp 1149523 

Diff: http://reviewboard.kde.org/r/4596/diff


Testing
-------

I tested this patch here locally and it makes the syncing of contact photos with my Android device working.


Thanks,

papillon81

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list