[Kde-pim] Review Request: Convert IMAP flags to internal Akonadi flags in the IMAP resource.

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4760/#review6715
-----------------------------------------------------------

Ship it!


Good for me now (apart from the whitespace issues outlined by the reviewboard).

Looking forward to the painful merging it'll generate in my branch. Help welcome. ;-)
(For the curious branches/work/~ervin/imap-resource-refactor)

- Kevin


On 2010-07-27 14:01:21, Leo Franchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4760/
> -----------------------------------------------------------
> 
> (Updated 2010-07-27 14:01:21)
> 
> 
> Review request for KDE PIM and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> As a result of the recent Akonadi server changes that have made the akonadi server case-sensitive for flags, the decision was made to store flags as all-uppercase. However, the flags from imap servers are not upper-cased, they are simply capitalized. This results in collection statistics always being incorrect (listing all items as unread).
> 
> After discussion with Tobias, a solution was proposed to do a mapping of KImap flags <--> Akonadi flags in the imap resource, as that is the interface between KImap and Akonadi. For now this just includes 4 standard imap server flags. I don't know if this is the best way to do this, but figured i'd throw it out there and start a discussion.
> 
>  Comments are appreciated :)
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdepim/runtime/resources/imap/CMakeLists.txt 1155485 
>   /branches/KDE/4.5/kdepim/runtime/resources/imap/imapflags.h PRE-CREATION 
>   /branches/KDE/4.5/kdepim/runtime/resources/imap/imapflags.cpp PRE-CREATION 
>   /branches/KDE/4.5/kdepim/runtime/resources/imap/imapresource.h 1155485 
>   /branches/KDE/4.5/kdepim/runtime/resources/imap/imapresource.cpp 1155485 
>   /branches/KDE/4.5/kdepimlibs/akonadi/kmime/CMakeLists.txt 1155485 
>   /branches/KDE/4.5/kdepimlibs/akonadi/kmime/messageflags.h PRE-CREATION 
>   /branches/KDE/4.5/kdepimlibs/akonadi/kmime/messageflags.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4760/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/