[Kde-pim] Review Request: Decode RFC 2047 encoded words in quoted-strings in headers.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4749/#review6687
-----------------------------------------------------------

Ship it!


Looks good to me.

- Thomas


On 2010-07-22 19:09:52, Leo Franchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4749/
> -----------------------------------------------------------
> 
> (Updated 2010-07-22 19:09:52)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Encoded words in quoted-strings are not allowed by RFC822. However, some clients send broken mail of this type, for example, older versions of KMail. Headers of this type:
> 
> "Ingo =?iso-8859-15?q?Kl=F6cker?=" <kloecker at kde.org>
> 
> will not be decoded. This patch checks for a starting =? to quoted-string words and attempts to decode them. If decoding fails, the quoted-string parsing continues as before. 
> 
> Also remove a QString.toLatin1() call that was relying on lower parts of the stack to not do the decoding.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdepimlibs/kmime/kmime_header_parsing.cpp 1153032 
>   /branches/KDE/4.5/kdepimlibs/kmime/tests/auto/headertest.cpp 1153032 
> 
> Diff: http://reviewboard.kde.org/r/4749/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/