[Kde-pim] Review Request: Junior Job complete: "Re-add ability to hide quick search"

[Richard Plangger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4382/
-----------------------------------------------------------

(Updated 2010-07-13 13:17:52.075464)


Review request for KDE PIM and Thomas McGuire.


Changes
-------

minor changes.

applied all hints but one given from tmcguire.

'In this function, you hide all widgets explicitly.

It is better to put the search bar, the toolbutton and the combobox into the same parent widget, and just hide that parent widget.
The parent widget would simply be an empty QWidget that has 0 margin.'

How would i do that?
Because:
* QWidgets do not have children
* Setting up a parent relation to one QWidget x, and hiding x afterwards do net affect the 3 children? 

Can someone give me advice?


Summary
-------

Junior Job "Re-add ability to hide quick search" (http://techbase.kde.org/Projects/PIM/KMail_Junior_Jobs#KMail_Junior_Jobs)

CTRL + H shows hides the searchbar, combobox and toolbutton!

This is my fist KDE patch, advice & criticism appreciated!


Diffs (updated)
-----

  trunk/KDE/kdepim/messagelist/core/widgetbase.h 1149337 
  trunk/KDE/kdepim/messagelist/core/widgetbase.cpp 1149337 
  trunk/KDE/kdepim/messagelist/widget.cpp 1149337 

Diff: http://reviewboard.kde.org/r/4382/diff


Testing
-------

Tested on local machine


Screenshots
-----------

before hitting ctrl + h
  http://reviewboard.kde.org/r/4382/s/436/
after
  http://reviewboard.kde.org/r/4382/s/437/


Thanks,

Richard

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/