[Kde-pim] Review Request: Make KMail filters fetch body only when necessary

Kevin Krammer kevin.krammer at gmx.at
Wed Jul 21 19:01:56 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4735/
-----------------------------------------------------------

Review request for KDE PIM and Thomas McGuire.


Summary
-------

I was seeing full payload fetches whenever clicking on a folder in KMail. The ETM used for the message list only fetches headers so the full payload requirement had to some from somewhere else.

Tracked it down to the Filter Manager, which set its ChangeRecorder's ItemFetchScope to full payload if one of the filter requires the body.
Which sounds OK on the first look, but the fetch scope of the changerecorder apply to all fetches, i.e. for all kinds of notifications and in all collections.

The filters are only run on itemAdded() and only for inboxes, so this delays the fetch scope change to those occasions.


Diffs
-----

  /branches/KDE/4.5/kdepim/kmail/kmfiltermgr.h 1152675 
  /branches/KDE/4.5/kdepim/kmail/kmfiltermgr.cpp 1152675 

Diff: http://reviewboard.kde.org/r/4735/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list