[Kde-pim] Review Request: korg: Disable Zoom, Day, Work Week and Week buttons when we can't use them

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2649/#review3807
-----------------------------------------------------------

Ship it!


nice!

- Allen


On 2010-01-23 00:40:59, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2649/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 00:40:59)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> According to Volker, beginning with 4.5, "Day", "Week" and "Work Week" buttons are no longer used for view selection but for date range selection. They are no longer tied to agenda. Now you can use them in timespent, timeline, journal-view, etc.
> 
> This patch disables them when in month and to-do view since they do nothing there ( besides confusing users ).
> 
> It also disables the zoom buttons on views that don't support zooming.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/actionmanager.cpp 1078804 
>   trunk/KDE/kdepim/korganizer/interfaces/korganizer/baseview.h 1078804 
>   trunk/KDE/kdepim/korganizer/interfaces/korganizer/baseview.cpp 1078804 
>   trunk/KDE/kdepim/korganizer/koviewmanager.cpp 1078804 
>   trunk/KDE/kdepim/korganizer/views/agendaview/agendaview.h 1078804 
>   trunk/KDE/kdepim/korganizer/views/monthview/monthview.h 1078804 
>   trunk/KDE/kdepim/korganizer/views/todoview/kotodoview.h 1078804 
> 
> Diff: http://reviewboard.kde.org/r/2649/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/