[Kde-pim] Review Request: korg: search dialog: add a label that indicates how many items were found

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2706/#review3905
-----------------------------------------------------------

Ship it!


nice.  please fix the plural item(s) string first before committing.


trunk/KDE/kdepim/korganizer/searchdialog.cpp
<http://reviewboard.kde.org/r/2706/#comment3275>

    can't you simply this by using i18np?
    
    eg. numItems->setText( i18np("%1 item","%1 items, mMatchedEvents.count()));
    


- Allen


On 2010-01-23 20:29:20, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2706/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 20:29:20)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I added a label that indicates how many items were found, see the screenshot.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/searchdialog.cpp 1079177 
>   trunk/KDE/kdepim/korganizer/searchdialog_base.ui 1079177 
> 
> Diff: http://reviewboard.kde.org/r/2706/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> search dialog
>   http://reviewboard.kde.org/r/2706/s/300/
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/