[Kde-pim] Review Request: Make kpilot work with latest EntityTreeModel and ServerManager classes.

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2507/#review3590
-----------------------------------------------------------


You'll make Ryan Rix happy with this I guess :). I've one question, which version of ETM is this patch meant for? 4.3.* or 4.4*, trunk? Whatever it is, I think you should also update the correct CMakeLists.txt to make sure that it is compiled against the right version of kdepimlibs.

- Bertjan


On 2010-01-06 08:09:12, Robert Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2507/
> -----------------------------------------------------------
> 
> (Updated 2010-01-06 08:09:12)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Even though kpilot is unmaintained, it can't hurt to keep it compilable.  This patch does just that by changing a constructor that no longer needs or takes an Akonadi::Session* parameter.  I would commit this without review, but I no longer have access to those files, I guess.
> 
> 
> Diffs
> -----
> 
>   /tags/unmaintained/4/kpilot/conduits/akonadibase/akonadisetupwidget.cc 1070612 
> 
> Diff: http://reviewboard.kde.org/r/2507/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Robert
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/