[Kde-pim] Review Request: Add lock / unlock capabilities to KJots (bug 163494)

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2698/#review3872
-----------------------------------------------------------

Ship it!


Reviewboard is letting me in now.

This patch is fine. 

Please remove the #include QPushButton and the commented use of it. The lock 
emblem will need to be implemented using a delegate but we can do that 
later.

Thanks for the patch. If you don't have an svn account let me know and I can 
commit it.

Steve.

- Stephen


On 2010-01-23 13:35:57, Hans Bakker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2698/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 13:35:57)
> 
> 
> Review request for KDE PIM and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> This patch is a proposal for the fixing of bug 163494, which asks for lock/unlock support of KJotsEntries. When multiple items are selected, they are all locked / unlocked. Locking a book also locks its pages.
> I implemented the lock / unlock action in the context menu of the bookshelf. KJotsEdit becomes read-only when a locked item is shown. Deleting is made impossible when an item is locked and an explanation is shown that the user must first unlock the item.
> Renaming is still possible.
> An extra entry in the .book files is made: <Locked>false</Locked> or <Locked>true</Locked> is used to store the lock status.
> 
> What could / should be improved is the visibility of locking-status: it would be better to have a lock-icon next to the items in the bookshelf, which would be half-transparent when it is unlocked and not transparent when it is locked. This item could then be made clickable to replace the lock / unlock actions in the context menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kjots/bookshelf.cpp 1078843 
>   /trunk/KDE/kdepim/kjots/kjotscomponent.h 1078843 
>   /trunk/KDE/kdepim/kjots/kjotscomponent.cpp 1078843 
>   /trunk/KDE/kdepim/kjots/kjotsedit.cpp 1078843 
>   /trunk/KDE/kdepim/kjots/kjotsentry.h 1078843 
>   /trunk/KDE/kdepim/kjots/kjotsentry.cpp 1078843 
> 
> Diff: http://reviewboard.kde.org/r/2698/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hans
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/