[Kde-pim] Review Request: Bug 86302 for kmail-4.4: Handle malformed multi-line mail headers

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2644/#review3758
-----------------------------------------------------------

Ship it!


Thanks, I committed this now in r1077597 and it should be available for KDE SC 4.4.0.

- Thomas


On 2010-01-18 20:15:12, Oldrich Jedlicka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2644/
> -----------------------------------------------------------
> 
> (Updated 2010-01-18 20:15:12)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Parse correctly malformed multi-line mail headers. When the next header line starts with =09/=20, it is apparently an encoded tab/space character that marks header continuation.
> 
> The solution is different to former kmime patch, because old kmail used mimelib and parsed messages itself too.
> 
> Fixes bug 86302 for kmail-4.4. This should not add any regression AFAICT.
> 
> 
> This addresses bug 86302.
>     https://bugs.kde.org/show_bug.cgi?id=86302
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.4/kdepim/kmail/kmfoldermaildir.cpp 1076243 
>   /branches/KDE/4.4/kdepim/kmail/kmfoldermbox.cpp 1076243 
>   /branches/KDE/4.4/kdepim/mimelib/entity.cpp 1076243 
>   /branches/KDE/4.4/kdepim/mimelib/headers.cpp 1076243 
> 
> Diff: http://reviewboard.kde.org/r/2644/diff
> 
> 
> Testing
> -------
> 
> Running kmail, opened wrongly coded mails. Example of wrongly coded header looks like this:
> 
> ...
> Cc: =?us-ascii?Q?linuxwacom=2Ddevel?= <linuxwacom-devel at lists.sourceforge.net>
> Subject: =?us-ascii?Q?Re=3A=20=5BLinuxwacom=2Ddevel=5D=20=5Bxsetwacom=5D=20xsetwacom=20=2D=2Dset=20=22WACOM=20Pen
> =09Tablet=22=20STopX0=20500=20fails?=
> ...
> 
> Note the =09 at the beginning of the second Subject line.
> 
> 
> Thanks,
> 
> Oldrich
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/