[Kde-pim] Review Request: Add support for multiple phone numbers and email addresses to akonadi googledata agent

[Stefano Avallone]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2502/
-----------------------------------------------------------

(Updated 2010-01-07 00:53:06.105937)


Review request for KDE PIM.


Changes
-------

Adenilson,

please find a new version of the patch. I think I have addressed all the comments from you and Kevin. I have not tried the pahole tool yet (hopefully I will do so soon). I have also pushed my patch against libgcal to my cloned repository on gitorious. Shall I issue a merge request? Once we agree on a final version for this patch, I will also try to make some unit tests.


Summary
-------

Currently, the akonadi googledata agent (and libgcal) does not support multiple phone numbers and email addresses per contact. This patch (along with a patch against libgcal, posted to the kde-extra-gear and kde-pim mailing lists) adds such support. An attempt is made to match Google labels for phone number types (work, home, etc.) and the label used by KAddressBook. Also, the group membership info associated with each Google contact is stored as a custom propoerty in Akonadi, thus this information is not lost when the contact is updated within KAddressBook.


Diffs (updated)
-----

  /trunk/extragear/pim/googledata/contacts/googledataresource.cpp 1066667 

Diff: http://reviewboard.kde.org/r/2502/diff


Testing
-------

I have done some tests with my Google account and it works. Also, a Chakra user reported it works for him, too.


Thanks,

Stefano

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/