[Kde-pim] Review Request: Add support for multiple phone numbers and email addresses to akonadi googledata agent

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2502/#review3580
-----------------------------------------------------------



/trunk/extragear/pim/googledata/contacts/googledataresource.cpp
<http://reviewboard.kde.org/r/2502/#comment2854>

    maybe use a const char* here, to indicate that it will not be changed in any way



/trunk/extragear/pim/googledata/contacts/googledataresource.cpp
<http://reviewboard.kde.org/r/2502/#comment2855>

    Not sure what Adenilson's coding style is so this is up to him, but I personally find it easier to read when conditions are real booleans instead of interpreting certain values of integers as boolean values, i.e. strcmp( label, "home" ) == 0



/trunk/extragear/pim/googledata/contacts/googledataresource.cpp
<http://reviewboard.kde.org/r/2502/#comment2856>

    use constBegin() and constEnd() to avoid the QStringList container from detaching its shared data, i.e. avoid it doing a deep copy.
    
    Since you don't have to change the list it is easier to use foreach()
    
    foreach( const QString &email, listEmail ) {
    }
    


- Kevin


On 2010-01-04 23:58:39, Stefano Avallone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2502/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 23:58:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently, the akonadi googledata agent (and libgcal) does not support multiple phone numbers and email addresses per contact. This patch (along with a patch against libgcal, posted to the kde-extra-gear and kde-pim mailing lists) adds such support. An attempt is made to match Google labels for phone number types (work, home, etc.) and the label used by KAddressBook. Also, the group membership info associated with each Google contact is stored as a custom propoerty in Akonadi, thus this information is not lost when the contact is updated within KAddressBook.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/pim/googledata/contacts/googledataresource.cpp 1066667 
> 
> Diff: http://reviewboard.kde.org/r/2502/diff
> 
> 
> Testing
> -------
> 
> I have done some tests with my Google account and it works. Also, a Chakra user reported it works for him, too.
> 
> 
> Thanks,
> 
> Stefano
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/