[Kde-pim] Review Request: KMail composer autosave functionality

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2556/#review3723
-----------------------------------------------------------

Ship it!


Thanks, committed in r1075672.
Seems to work nicely :)

I have made some small changes after committing, which are:
- Change messagebox caption from "autosave" to something more meaningful, e.g. "Opening Autosave File Failed"
- In writeAutoSaveToDisk() removed code duplication to only have one call to KMessageBox::sorry() instead of 3
- Coding style fixes like removing trailing whitespace
- Removing a few kDebugs and removing not needed spaces inside the kdebug srings
- Reworded the error message that said "because %2", which wouldn't work, since QFile::errorString() returns a complete sentence

- Thomas


On 2010-01-13 15:14:52, Matthew Leach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2556/
> -----------------------------------------------------------
> 
> (Updated 2010-01-13 15:14:52)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch will add autosave functionality to the KMail composer window.
> 
> 
> Diffs
> -----
> 
>   /branches/work/akonadi-ports/kdepim/kmail/kmcomposewin.h 1073933 
>   /branches/work/akonadi-ports/kdepim/kmail/kmcomposewin.cpp 1073933 
>   /branches/work/akonadi-ports/kdepim/kmail/kmkernel.cpp 1073933 
>   /branches/work/akonadi-ports/kdepim/kmail/composer.h 1073933 
> 
> Diff: http://reviewboard.kde.org/r/2556/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthew
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/