[Kde-pim] Review Request: open the combo when clicking on to-do view's "Select Categories" text

Allen Winter winter at kde.org
Fri Jan 8 23:30:40 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2532/#review3607
-----------------------------------------------------------

Ship it!


looks fine.

- Allen


On 2010-01-08 23:19:39, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2532/
> -----------------------------------------------------------
> 
> (Updated 2010-01-08 23:19:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I've been using to-do view a lot and noticed some usability problems/bugs. When clicking on the "Select Categories" combo, to filter some to-dos, nothing happens. If I want to open the combo I have to click on the right side (see attached image).
> 
> This combo has an internal KLineEdit that's receiving the mouse event. Since we don't use the KLineEdit for editing, only for caption I filtered the event and called showPopup().
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/libkdepim/kcheckcombobox.cpp 1070885 
> 
> Diff: http://reviewboard.kde.org/r/2532/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Clickable zone
>   http://reviewboard.kde.org/r/2532/s/293/
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list