[Kde-pim] Patch for exclude some special resources

[laurent Montel]

Le Lundi 8 Février 2010 00:35:51, Stephen Kelly a écrit :
> laurent Montel wrote:
> > Le Samedi 6 Février 2010 16:23:42, laurent Montel a écrit :
> >> Hi,
> >> Yesterday I added some function to CollectionFilterProxyModel to exclude
> >> some resources from list of collection.
> >> 
> >> Could you review it please ? (I fixed some remark from Tobias)
> >> 
> >> And perhaps we can add other enum for other type of resources.
> >> 
> >> Thanks
> 
> Hi,

Hi,

> I have looked through the patch, and while it might have the effect you're
> looking for, I don't think it's the right solution.
> 
> I think the right solution is to not include those resources in the
> entitytreemodel in the first place, and explicitly include them when you
> really want them.
> http://thread.gmane.org/gmane.comp.kde.devel.pim/25372

ok

> http://techbase.kde.org/Projects/PIM/Akonadi/VirtualCollections
> 
> The problem is that the number of virtual search collections we have is
> likely to grow, and you don't necessarily want all of the virtual
> collections from random plasmoids or other apps to be in kmails search
> tree.
> 
> I discovered a while ago that search collections were getting the mimetype
> of their search result added to their content mimetype. I don't know when
> that happened, but I think it was the wrong way to go and I'd like
> to see it reversed and use the monitor->setResourceMonitored (...) method
> instead. I'll try to do that this week I guess.
> 
> That would mean your patch is not necessary I think

If you will success to do it, yes my patch will not necessary.
 
> All the best,
> 
> Steve.

Regards

-- 
Laurent Montel | laurent at kdab.com | KDE/Qt Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/