[Kde-pim] Review Request: Port of KMail from KSystemTrayIcon to KStatusNotifierItem

[Aurélien Gâteau]

> On 2010-02-19 13:03:56, Thomas McGuire wrote:
> > Seems straightforward, so please commit.
> > 
> > > Tested both "always visible" and "only on new messages" modes. Works OK.
> > 
> > Really, does this even work with trunk KMail, i.e. KMail 2?
> > If so, good news, I didn't know the unread count calculation works.

Mmmm... in fact I tested with my 4.4 backport.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3007/#review4219
-----------------------------------------------------------


On 2010-02-19 11:52:10, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3007/
> -----------------------------------------------------------
> 
> (Updated 2010-02-19 11:52:10)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a port of KMail from KSystemTrayIcon to KStatusNotifierItem. Most of the work is in r1 of the diff, r2 is an improvement which makes use of KStatusNotifierItem overlays.
> 
> Note: for overlays to work you need a recent (svn rev >= 1092306) systemtray applet.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmsystemtray.h 1059607 
>   trunk/KDE/kdepim/kmail/kmsystemtray.cpp 1059607 
> 
> Diff: http://reviewboard.kde.org/r/3007/diff
> 
> 
> Testing
> -------
> 
> Tested both "always visible" and "only on new messages" modes. Works OK.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/