[Kde-pim] Re: Review Request: Fix the Apply button behaviour in the Configure Filters dialog (Bug 123548)

[George Metaxas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6061/
-----------------------------------------------------------

(Updated 2010-12-08 09:01:57.070497)


Review request for KDE PIM.


Changes
-------

Addressed all comments by Andras Mantia (thank you for your comments), such as: 
 - unnecessary QObject:: prefix in a QObject subclass, 
 - the FilterAction and subclasses constructors now follow the QObject style, 
 - removed unnecessary inherited signals in FilterAction subclasses. 
Also I made all changes in the patch follow the KDE PIM style guide.


Summary
-------

Currently, the Apply button in the Configure Dialog is always enabled. This is because the button was simply added to the dialog and left unconnected to the dialog's logic. This patch implements the behaviour of the Apply button, by enabling it when a value in the dialog has changed. Apart from connecting an appropriate signal of each widget in the dialog to the Apply button logic, some signal/slot implementation was required in various classes of the MailCommon namespace, to enable the notification of a value change in some of the provided widgets (e.g. SoundTestWidget, SearchPatternEdit) or classes (e.g. FilterAction and subclasses).


This addresses bug 123548.
    https://bugs.kde.org/show_bug.cgi?id=123548


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmfilterdlg.h 1204467 
  /trunk/KDE/kdepim/kmail/kmfilterdlg.cpp 1204467 
  /trunk/KDE/kdepim/mailcommon/filteraction.h 1204467 
  /trunk/KDE/kdepim/mailcommon/filteraction.cpp 1204467 
  /trunk/KDE/kdepim/mailcommon/filteractionwidget.h 1204467 
  /trunk/KDE/kdepim/mailcommon/filteractionwidget.cpp 1204467 
  /trunk/KDE/kdepim/mailcommon/searchpatternedit.h 1204467 
  /trunk/KDE/kdepim/mailcommon/searchpatternedit.cpp 1204467 
  /trunk/KDE/kdepim/mailcommon/soundtestwidget.h 1204467 
  /trunk/KDE/kdepim/mailcommon/soundtestwidget.cpp 1204467 

Diff: http://svn.reviewboard.kde.org/r/6061/diff


Testing
-------

Tested the dialog by adding/removing/changing filters, altering filter order, adding/removing/altering filter actions, adding/removing/altering filter criteria.


Thanks,

George

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/