[Kde-pim] Re: Review Request: kmail: fix 260593 bug

Torgny Nyblom kde at nyblom.org
Thu Dec 30 13:20:06 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100260/#review671
-----------------------------------------------------------

Ship it!


Looks good to me.

One minor thing, Please use a more descriptive subject when creating the request.

/Regards
Torgny

- Torgny


On 2010-12-28 21:04:49, Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100260/
> -----------------------------------------------------------
> 
> (Updated 2010-12-28 21:04:49)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This patch is fixing the 260593 bug report... I have not upload any snapshot because the bug has nothing to do with the ui of kmail but if you want snapshots then let me know... Also the same bug appears in the templates (templates are below the drafts). So i made the patch to fix them both...
> 
> 
> This addresses bug 260593.
>     http://bugs.kde.org/show_bug.cgi?id=260593
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.cpp 84b6fe8 
> 
> Diff: http://git.reviewboard.kde.org/r/100260/diff
> 
> 
> Testing
> -------
> 
> The kmail compiles without any issue...
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list