[Kde-pim] Re: Review Request: Output error message when saving an attachment to a disk, which becomes full - Bug 127981

[Ingo Klöcker]

> On 2010-12-12 23:14:05, Ingo Klöcker wrote:
> > As far as I'm concerned you can commit your fix now. Thanks!
> 
> George  Metaxas wrote:
>     I do not yet have an SVN account, so you (or someone else) will have to commit this on my behalf. Thank you for your comments.

Committed with revision 1206073.

I'm looking forward to more patches. :-)


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6104/#review9221
-----------------------------------------------------------


On 2010-12-12 19:17:09, George  Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6104/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 19:17:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> As discussed in Bug 127981, when one attempts to save an attachment to a disk which has some space available, but not enough to fit the attachment, KMail will not output an error message informing the user about this. Instead, the attachment will be partially saved and the user will be oblivious to what really happened. This patch will show an error message to the user and will also remove the partially written file. KMail does indeed correctly inform the user if the disk has no space left, but it leaves behind a zero-sized file. This patch also removes this unnecessary file.
> 
> 
> This addresses bug 127981.
>     https://bugs.kde.org/show_bug.cgi?id=127981
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/messageviewer/util.cpp 1205704 
> 
> Diff: http://svn.reviewboard.kde.org/r/6104/diff
> 
> 
> Testing
> -------
> 
> Tested saving an attachment with:
> - No space left
> - Some space left, but not enough to fit the attachment
> - Enough space to fit the attachment
> 
> 
> Thanks,
> 
> George
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/