[Kde-pim] Re: Review Request: Removing "local folder" entry from file menu in kmail2

[Ingo Klöcker]

> On 2010-12-15 12:08:03, Andras Mantia wrote:
> > See my reply to the bug report. Also this "find the agent by name" doesn't seem to be a very good idea. There is also a mixedmaildir resource for instance. And an mbox one as well, no? And the local accounts can be used to monitor mails delivered locally to you, and in that case a check mail is useful.

I'm not sure that it's useful. I think local accounts should always be checked automatically by monitoring the corresponding mail folders. Alternatively, it should be configurable whether a local account shall be monitored (which makes manual checking superfluous) or not monitored (then manual checking would be necessary).


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6117/#review9255
-----------------------------------------------------------


On 2010-12-15 10:57:05, Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6117/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 10:57:05)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This patch is fixing the "- Check Mail In: Has useless submenu entry "Local Folders" ", please take a look in my reply in the 223818 bug report... I have remove that entry because it doesn't make any sense...
> 
> 
> This addresses bug 223818.
>     https://bugs.kde.org/show_bug.cgi?id=223818
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1204345 
> 
> Diff: http://svn.reviewboard.kde.org/r/6117/diff
> 
> 
> Testing
> -------
> 
> The patch is working and the kmail compiles without any problem.
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://svn.reviewboard.kde.org/r/6117/s/581/
> after
>   http://svn.reviewboard.kde.org/r/6117/s/582/
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/