[Kde-pim] Re: Review Request: Implement multiple item selection functionality in the KEditListBox and KEditListWidget widgets (Bug 219574)

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6176/#review9395
-----------------------------------------------------------


You need to split this into two patches now that kdepim has moved to git, or wait for after the 4.6.0 release when kdelibs are moving as well.

- Torgny


On 2010-12-21 13:22:16, George  Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6176/
> -----------------------------------------------------------
> 
> (Updated 2010-12-21 13:22:16)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Bug 219574 refers to the addition of functionality to allow multiple item selection in the Edit Recent Addresses dialog, of the KMail configuration dialog. The Edit Recent Addresses dialog makes use of a KEditListWidget (or a KEditListBox depending on the KDE4 version) for almost all of the functionality provided by the dialog. It is not possible to add this feature to the Edit Recent Addresses dialog solely, unless it is re-written to use a standard list view widget. Consequently, the requested feature has been added to the core KEditListBox and KEditListWidget classes. Both the removal and  moving of multiple items has been supported. The required modifications were performed to classes that are part of kdelibs.
> 
> 
> This addresses bug 219574.
>     https://bugs.kde.org/show_bug.cgi?id=219574
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp 1208133 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h 1208133 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h 1208133 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.cpp 1208133 
>   /trunk/KDE/kdepim/libkdepim/recentaddresses.cpp 1208142 
> 
> Diff: http://svn.reviewboard.kde.org/r/6176/diff
> 
> 
> Testing
> -------
> 
> Tested:
> - Removal of a single item
> - Removal of multiple items
> - Moving a single item.
> - Moving multiple selected items (in different selection patterns).
> 
> The capability to move multiple items was not tested with the code in the Edit Recent Address dialog, because it does not support item movement.
> 
> 
> Thanks,
> 
> George
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/